- From: Domenic Denicola <web-platform-tests-notifications@w3.org>
- Date: Mon, 06 Mar 2017 15:44:34 GMT
- To: public-web-platform-tests-notifications@w3.org
I think the comments need to be trimmed significantly. The vast majority of time the comments added in this pull request are of the useless variety, similar to ```js // add 5 to x x += 5; ``` For example, I would trim the comments in `browsing-context-created--window.html` down to ``` // This test is separate from the rest of the browsing-content-creation tests // because the `iframe` has a src and thus its document won't be `about:blank`. ``` Everything else is redundant and re-stating what is stated already in either the title of the test or the assertion messages. I think we've seen this kind of explicit 1:1 test/spec correspondence go stale badly already with the XMLHttpRequest tests. View on GitHub: https://github.com/w3c/web-platform-tests/pull/5040#issuecomment-284434450
Received on Monday, 6 March 2017 15:44:47 UTC