Re: [streams-tests] streams/r-b-s: eliminate asserts from try blocks (#4633)

> Fix this by moving asserts out of pull() methods, usually by copying the
> value being checked and verifying it after pull() has returned.

Another fix would have been to just wrap all these async methods in Test.step_func. And for things where you're trying to assert a method doesn't get called, passing Test.unreached_func() as that method seems simpler than having a variable, setting that variable, and then later checking that the variable didn't get changed.

View on GitHub: https://github.com/w3c/web-platform-tests/pull/4633#issuecomment-275484411

Received on Thursday, 26 January 2017 19:18:59 UTC