Re: [service-workers-tests] [service-workers] Correct test cleanup logic (#4944) from Marijn Kruisselbrink on 2017-02-21 (public-web-platform-tests-notifications@w3.org from February 2017)

From: Marijn Kruisselbrink <web-platform-tests-notifications@w3.org>
Date: Tue, 21 Feb 2017 19:55:55 GMT
To: public-web-platform-tests-notifications@w3.org
Message-Id: <<web-platform-tests_issue_4944_1487706955756@w3.org>>

Ah yes, you're right. All the async code is already correctly wrapped in step_func. Sorry for the confusion.

And this change LGTM. One tiny nit maybe would be that promise rejections in the onPortReady method (if with_iframe fails for some reason) are currently ignored. 

View on GitHub: https://github.com/w3c/web-platform-tests/pull/4944#issuecomment-281461226

Received on Tuesday, 21 February 2017 19:56:11 UTC