- From: Philip Jägenstedt <web-platform-tests-notifications@w3.org>
- Date: Thu, 27 Apr 2017 08:05:59 GMT
- To: public-web-platform-tests-notifications@w3.org
>> Do you mean https://w3c.github.io/webrtc-pc/#peer-to-peer-connections? AFAICT all the IDL from the spec has been copied. > > All the IDL definitions have been copied from the spec. However only objects of IDLs in https://w3c.github.io/webrtc-pc/#peer-to-peer-connections are constructed for testing. Can you add TODOs for the rest? It will not be obvious from the test at a glance which interfaces aren't tested with instances. >> Do you need to do some kind of cleanup, or what is the X? > > The call to `idlArray.add_objects()` are asynchronous inside nested promise_test. The final `idlArray.test()` tests all added objects in one go, and should be called only when the sub promise_tests are done. (Is nested testing allowed with testharness?) I think that with the suggested changes, you should end up with just a single explicit `promise_test`, which as its last step will call `idlArray.test()`, so hopefully this need will disappear. (It is possible to test tests, e.g. to create one `async_test` at the end of another. I always find it harder to follow though, so avoid it where possible.) View on GitHub: https://github.com/w3c/web-platform-tests/pull/5712#issuecomment-297643147
Received on Thursday, 27 April 2017 08:06:11 UTC