Re: [streams-tests] ReadableStream: pipeThrough() is not fooled by a fake Promise (#5519)

My confusion was due to there being two behaviors under test here:

1. Invocation of various Promise instance methods (or the lack thereof)
2. Referencing of the [[PromiseHandled]] internal slot (or lack thereof)

There are in-line comments that explain each (thanks for those), but they are
actually orthogonal behaviors, and their pre-conditions are likewise unrelated.
This is what confused me. I would have understood this initially if this were
expressed as two distinct tests: one that used a "true" Promise with overridden
instance methods, and one that used a "fake" Promise.

Thanks for following up with this! I really appreciate your making the effort
to iterate on this... But now that I understand the intent, I can see that my
feedback does not effect the test's efficacy, so I'm happy to let this
go. You've documented the code well, after all.

View on GitHub: https://github.com/w3c/web-platform-tests/pull/5519#issuecomment-293916912

Received on Thursday, 13 April 2017 14:47:21 UTC