- From: Andreas Tolfsen <web-platform-tests-notifications@w3.org>
- Date: Fri, 07 Apr 2017 17:48:54 GMT
- To: public-web-platform-tests-notifications@w3.org
Reviewed 2 of 9 files at r2, 7 of 7 files at r3.
Review status: all files reviewed at latest revision, 16 unresolved discussions.
---
*[webdriver/conftest.py, line 22 at r1](https://reviewable.io:443/reviews/w3c/web-platform-tests/5187#-Kgy8Tjbgfm34LawmH1h-r1-22:-Kh8U6c3HvoBksfCqIs9:b-ljil3a) ([raw file](https://github.com/w3c/web-platform-tests/blob/4a3af5aefba5e14d93c0670615566d06a13c1bcb/webdriver/conftest.py#L22)):*
> resp, _ = new_session({"capabilities": {}})
> with pytest.raises(error.SessionNotCreatedException):
---
*[webdriver/newsession/basic.py, line 16 at r3](https://reviewable.io:443/reviews/w3c/web-platform-tests/5187#-Kh8Ud98WAPvDfuRPg9G:-Kh8Ud98WAPvDfuRPg9H:b4lm655) ([raw file](https://github.com/w3c/web-platform-tests/blob/009d0fae9daf0b84a59d081d66e6362d8329308f/webdriver/newsession/basic.py#L16)):*
> ```Python
>
> def test_repeat_new_session(new_session):
> resp, _ = new_session({"capabilities": {}})
> ```
`resp` not used.
---
*[webdriver/newsession/basic.py, line 27 at r3](https://reviewable.io:443/reviews/w3c/web-platform-tests/5187#-Kh8UjZqDqqXAOtFyQ8L:-Kh8UjZqDqqXAOtFyQ8M:b4lm655) ([raw file](https://github.com/w3c/web-platform-tests/blob/009d0fae9daf0b84a59d081d66e6362d8329308f/webdriver/newsession/basic.py#L27)):*
> ```Python
>
> def test_missing_first_match(new_session):
> resp, _ = new_session({"capabilities": {"alwaysMatch": {}}})
> ```
`resp` not used.
---
*[webdriver/newsession/basic.py, line 31 at r3](https://reviewable.io:443/reviews/w3c/web-platform-tests/5187#-Kh8UlAr7eSAk5948qEL:-Kh8UlAr7eSAk5948qEM:b4lm655) ([raw file](https://github.com/w3c/web-platform-tests/blob/009d0fae9daf0b84a59d081d66e6362d8329308f/webdriver/newsession/basic.py#L31)):*
> ```Python
>
> def test_missing_always_match(new_session):
> resp, _ = new_session({"capabilities": {"firstMatch": [{}]}})
> ```
`resp` not used.
---
*[webdriver/newsession/basic.py, line 36 at r3](https://reviewable.io:443/reviews/w3c/web-platform-tests/5187#-Kh8UstvfdAgcojnfCcQ:-Kh8UstvfdAgcojnfCcR:b4lm655) ([raw file](https://github.com/w3c/web-platform-tests/blob/009d0fae9daf0b84a59d081d66e6362d8329308f/webdriver/newsession/basic.py#L36)):*
> ```Python
> def test_desired(new_session):
> with pytest.raises(error.InvalidArgumentException):
> resp, _ = new_session({"desiredCapbilities": {}})
> ```
`resp` not used.
---
*[webdriver/newsession/basic.py, line 41 at r3](https://reviewable.io:443/reviews/w3c/web-platform-tests/5187#-Kh8Utoyun9nbaWfC9-8:-Kh8Utoyun9nbaWfC9-9:b4lm655) ([raw file](https://github.com/w3c/web-platform-tests/blob/009d0fae9daf0b84a59d081d66e6362d8329308f/webdriver/newsession/basic.py#L41)):*
> ```Python
> def test_required(new_session):
> with pytest.raises(error.InvalidArgumentException):
> resp, _ = new_session({"requiredCapbilities": {}})
> ```
`resp` not used.
---
*[webdriver/newsession/basic.py, line 47 at r3](https://reviewable.io:443/reviews/w3c/web-platform-tests/5187#-Kh8UvT1p5wyC7jrpSPC:-Kh8UvT1p5wyC7jrpSPD:b6vokyw) ([raw file](https://github.com/w3c/web-platform-tests/blob/009d0fae9daf0b84a59d081d66e6362d8329308f/webdriver/newsession/basic.py#L47)):*
> ```Python
> with pytest.raises(error.InvalidArgumentException):
> resp, _ = new_session({"requiredCapbilities": {},
> "desiredCapbilities": {}})
> ```
`resp` not used, and the last line’s indentation is strange.
---
*[webdriver/newsession/create.py, line 1 at r3](https://reviewable.io:443/reviews/w3c/web-platform-tests/5187#-Kh8VbYciw32nEzaLU8O:-Kh8VbYciw32nEzaLU8P:b-sapsai) ([raw file](https://github.com/w3c/web-platform-tests/blob/009d0fae9daf0b84a59d081d66e6362d8329308f/webdriver/newsession/create.py#L1)):*
> ```Python
> #META: timeout=long
> ```
This file should probably be called `valid_capabilities.py` or similar, which pairs well with the next file, `invalid_capabilities.py`.
---
*[webdriver/newsession/invalid_capabilities.py, line 46 at r3](https://reviewable.io:443/reviews/w3c/web-platform-tests/5187#-Kh8WNklXMNb2_cgpe2_:-Kh8WNklXMNb2_cgpe2a:bmu3l37) ([raw file](https://github.com/w3c/web-platform-tests/blob/009d0fae9daf0b84a59d081d66e6362d8329308f/webdriver/newsession/invalid_capabilities.py#L46)):*
> ```Python
> {" pageLoad": 10}, {"pageLoad ": 10}]),
> ("unhandledPromptBehavior", [1, [], {}, False, "DISMISS", "dismissABC", "Accept",
> " dismiss", "dismiss "])
> ```
Missing `setWindowRect`.
---
*Comments from [Reviewable](https://reviewable.io:443/reviews/w3c/web-platform-tests/5187)*
<!-- Sent from Reviewable.io -->
View on GitHub: https://github.com/w3c/web-platform-tests/pull/5187#issuecomment-292605568
Received on Friday, 7 April 2017 17:49:07 UTC