Re: [service-workers-tests] Upstream service worker `client` tests to WPT (#5307)

Sorry to come to this late. It'd be unfortunate to not accept this change and to revert the change in Chromium.

Is the rationale for not accepting flakiness because the flakiness is typically the fault of the test rather than the browser?

In this case, Mike seems to have identified the Chrome bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=701233#c3

My preference would be to keep this change locally and in WPT. In Chrome, we've broken down the service worker WPT test effort into two subtasks that will run in parallel:
- Upstream correct tests
- Get Chrome to pass the tests

It'd be painful for us to block one on the other in general.

But in this case, since just one test failing, we could also revise the patch to not include this flaky test, and keep the flaky test in http/tests/serviceworker only.

View on GitHub: https://github.com/w3c/web-platform-tests/pull/5307#issuecomment-292063114

Received on Thursday, 6 April 2017 04:03:57 UTC