- From: Rick Byers <web-platform-tests-notifications@w3.org>
- Date: Thu, 15 Sep 2016 20:39:10 GMT
- To: public-web-platform-tests-notifications@w3.org
Sorry for the delay, this wasn't in my GitHub notifications for some reason... > I appreciate any comments regarding the refactoring if you have some ideas. I also removed the non-necessary tests in the test suite (i.e. these attribute tests test all those scenarios). I was wondering if we would like to just keep them around as they are testing smaller things or do we like to retire them in the favor of doing less manual work for testing all the test suite manually. Yeah it's not obvious how to do this best, especially given the constraint that it can't be too awkward or time consuming to run the test manually. I think what you've done is fine. We have a bit of a problem with tons of copy/paste in this test-suite but that of course all pre-dated you. Hopefully we'll overhaul it all once we have an automated input API. LGTM View on GitHub: https://github.com/w3c/web-platform-tests/pull/3668#issuecomment-247448615
Received on Thursday, 15 September 2016 20:39:19 UTC