- From: Tomoyuki Shimizu <web-platform-tests-notifications@w3.org>
- Date: Mon, 17 Oct 2016 05:08:27 GMT
- To: public-web-platform-tests-notifications@w3.org
@tidoust Thanks for your review! > I would drop the `test` lines here and rather complete the `assert_xxx` statements with the failure reason Okay, I removed nested `test()` and moved failure reason to `assert_xxx`. > We could probably also prefix the test's label with `[Optional]` so that it's easy to spot that the failure may simply indicate lack of support for the feature. I added `[Optional]` prefix to the test name. > It may be better to add a button that makes the test fail and instruct the user to press that button if the browser does not support `defaultRequest`. For now, I added the button to make the test fail. Since the current spec does not provide any hint about availability of `defaultRequest` for web apps, I cannot imagine any solution but using such a button... View on GitHub: https://github.com/w3c/web-platform-tests/pull/3977#issuecomment-254113668
Received on Monday, 17 October 2016 05:08:34 UTC