- From: François Daoust <web-platform-tests-notifications@w3.org>
- Date: Tue, 11 Oct 2016 11:47:01 GMT
- To: public-web-platform-tests-notifications@w3.org
Hi @tomoyukilabs,
Code seems good. Thanks! 3 comments:
1. The test suite already contains a similar test for step 11 under the name `startNewPresentation_error-manual.html`. This test has a bug though (see #3527). Your version fixes that bug and also gives the file a more explicit name. That's all good! Could your PR also delete `startNewPresentation_error-manual.html`?
2. I created a PR on testharness.js to include `NotAllowedError` in the list of DOMException (see https://github.com/w3c/testharness.js/pull/216). Once merged, you should be able to replace `new DOMException('', 'NotAllowedError')` by `'NotAllowedError'`.
3. For step 10, the _will remain so_ condition in the spec leaves the door open for implementers to simply wait forever and never fail with a `NotFoundError`. I don't have really better suggestions, I think we should include this test and see how browsers behave.
View on GitHub: https://github.com/w3c/web-platform-tests/pull/3880#issuecomment-252895246
Received on Tuesday, 11 October 2016 11:47:09 UTC