- From: François Daoust <web-platform-tests-notifications@w3.org>
- Date: Tue, 29 Nov 2016 10:24:02 GMT
- To: public-web-platform-tests-notifications@w3.org
On top of comments raised by @tomoyukilabs, I think the call to `terminate` should be moved to an `add_cleanup` call, to make sure it runs even if the assertion fails. I raised issue #4258 to track this across tests, because that affects other tests as well. @tomoyukilabs I don't think the call to `step_timeout` can be done *before* the call to `start()`: timeout should only start once the user is done with the dialog box, meaning when the `Promise` is resolved. Note on-going PR #4222 from @obstschale to fix related issue #4040 (no conflict but it seems good to make sure people are aware of related efforts). @mfoltzgoogle let us know if you'd rather merge this and let others work on remaining comments (timeout, cleanup step, file renaming, considering move to `promise_test`) in another PR. View on GitHub: https://github.com/w3c/web-platform-tests/pull/4256#issuecomment-263532528
Received on Tuesday, 29 November 2016 10:24:14 UTC