- From: Tomoyuki Shimizu <web-platform-tests-notifications@w3.org>
- Date: Tue, 29 Nov 2016 06:41:45 GMT
- To: public-web-platform-tests-notifications@w3.org
I have a couple of comments below, about PresentationConnection_onconnected-manual.html and PresentationConnection_onterminated-manual.html:
* If I understand this correctly, it fixes the items 2. and 3. mentioned in https://github.com/w3c/web-platform-tests/issues/4040#issue-184229288. I believe that we can also fix 1. by adding `step_timeout()` like below:
```js
var request = new PresentationRequest(presentationUrls);
step_timeout({
t.force_timeout();
t.done();
});
request.start()
.then(function(connection) { // ...
```
* These files should be renamed to PresentationConnection_onconnect-manual.html and PresentationConnection_onterminate-manual.html.
View on GitHub: https://github.com/w3c/web-platform-tests/pull/4256#issuecomment-263489708
Received on Tuesday, 29 November 2016 06:41:57 UTC