- From: Aryeh Gregor <web-platform-tests-notifications@w3.org>
- Date: Thu, 05 May 2016 18:22:35 GMT
- To: public-web-platform-tests-notifications@w3.org
There's no need to duplicate things that are already tested elsewhere, but if the same basic tests are repeated in two files for two different scenarios with different expected results, they should probably be merged into one file if that reduces code duplication. (E.g., have a helper function that takes the expected output as the argument or figures out the expected values programmatically or such.) It's fine to put a bunch of changes to one test in one pull request, IMO, although if you prefer you could put it in multiple commits. If you make multiple changes to one test in multiple simultaneous pull requests, you run the risk of merge conflicts, so that's not a good idea (unless you're sure they can be automatically merged). View on GitHub: https://github.com/w3c/web-platform-tests/pull/2951#issuecomment-217233035
Received on Thursday, 5 May 2016 18:22:44 UTC