- From: Domenic Denicola <web-platform-tests-notifications@w3.org>
- Date: Tue, 03 May 2016 15:35:40 GMT
- To: public-web-platform-tests-notifications@w3.org
Lots of minor suggestions and fixes, but overall these are great, comprehensive tests. Exactly the kind I was hoping someone would write, as a counterpart to my attempt at making the spec as detailed and algorithmic as possible. Here is what I see as remaining coverage, in addition to my line comments about increasing steps 12, 14, and 16 coverage: - Test something with a throwing `prototype` getter and make sure the exception is rethrown (step 10). - Test something with a throwing `observedAttributes` getter and make sure the exception is rethrown (step 8). - Test various things that cannot be converted to a Web IDL sequence as `observedAttributes`, and make sure the appropriate exception is thrown. See https://heycam.github.io/webidl/#es-sequence (Step 9) - Test various things that *can* be converted to a Web IDL sequence as `observedAttributes`. This might need to be part of a separate set of tests that tests observedAttributes in general. View on GitHub: https://github.com/w3c/web-platform-tests/pull/2940#issuecomment-216568799
Received on Tuesday, 3 May 2016 15:35:48 UTC