Re: [WebCryptoAPI-tests] Webcrypto encrypt and decrypt tests (#3110)

Based on my review I think the following tests are missing:
1  the algorithm of the key and the algorithm of the function do not match
2. algorithms which do not support the encrypt/decrypt operation
3. missing aad for the GCM algorithm
4. Change of the input array after the function call has been made

I am not overly happy with the idea of using a time out to decide if all of the tests have been setup.  It might be better to break the tests up into two steps:
Step 1 - Do the import of all of the keys.
Step 2 - when that is finished (based on Promise.all) then start all of the tests and use a normal done.  Note that this does mean that you need to mark the done as being deferred for the html tests.


View on GitHub: https://github.com/w3c/web-platform-tests/pull/3110#issuecomment-224039483

Received on Monday, 6 June 2016 18:06:47 UTC