Re: [websockets-tests] Echo status code and reason in websocket /echo handler (#2498) from Simon Pieters on 2016-01-19 (public-web-platform-tests-notifications@w3.org from January 2016)

From: Simon Pieters <web-platform-tests-notifications@w3.org>
Date: Tue, 19 Jan 2016 15:23:09 GMT
To: public-web-platform-tests-notifications@w3.org
Message-Id: <<web-platform-tests_issue_2498_1453216989656@w3.org>>

If someone is interested in history here: IIRC the top-level tests were submitted by Microsoft, and it appears they ended up reusing the existing `echo` handler even though it didn't echo the close reason.

I was a bit worried that this change would regress other websocket tests, but I didn't find anything that checked `reason` other than `interfaces/CloseEvent/constructor.html` which just creates the event in JS. So...

LGTM

View on GitHub: https://github.com/w3c/web-platform-tests/pull/2498#issuecomment-172886882

Received on Tuesday, 19 January 2016 15:23:16 UTC