- From: wolenetz <web-platform-tests-notifications@w3.org>
- Date: Wed, 31 Aug 2016 00:48:29 GMT
- To: public-web-platform-tests-notifications@w3.org
Thank you, @shishimaru for producing this PR so long ago. In the interim, many other sources, especially Chromium, W3C, Edge and Firefox folks have updated the test suite such that much of what is covered in tests by this PR is currently already covered in other tests, unified with some helper utilities to simplify maintainability too (mediasource-utils.js). Examining this PR vs current test suite, it looks like only the following pieces are missing from the test suite (but in this PR): 1. addSourceBuffer(null) should result in TypeError (not NotSupportedError as currently expected by mediasource-addsourcebuffer.html) 2. isTypeSupported(mime) returning true should mean that canPlayType(mime) is either "maybe" or "probably" (and certainly not ""). This can be added to mediasource-is-type-supported.html 3. Explicitly test isTypeSupported for each of: "xxx", "text/html", "image/jpeg" result in false. These can be added to mediasource-is-type-supported.html. 4. Explicitly test sourceBuffers added to distinct MediaSource objects give error when they are used in removeSourceBuffer to the wrong MediaSource. This can be added to mediasource-removesourcebuffer.html I will take care of fixing these 4 gaps in a new PR. Thank you, again @shishimaru, for putting these tests together so long ago. Please reactivate this PR if you have any related concern to my decision to close it and fix the known gaps in a smaller separate PR. View on GitHub: https://github.com/w3c/web-platform-tests/pull/823#issuecomment-243626531
Received on Wednesday, 31 August 2016 00:48:37 UTC