- From: jan-ivar <web-platform-tests-notifications@w3.org>
- Date: Tue, 19 May 2015 12:53:31 GMT
- To: public-web-platform-tests-notifications@w3.org
This is a variation of signaling after createOffer, with the same problems I outlined earlier. By not waiting for setLocalDescription to verify the offer, there's error fan-out. i.e. if setLocalDescription fails for any reason then the signaling is already on its way to the peer, creating more failures than seems neecssary. Also, I consider any delaying of setLocalDescription callback to be a footgun. It's the one method that is extremely time-sensitive in our API. Any guarantees about ice candidates not firing until after the setLocalDescription callback fires are lost here by waiting for both setLocal and setRemote to finish. I don't think we should worry about the time it takes setLocalDescription to finish. View on GitHub: https://github.com/w3c/web-platform-tests/pull/1824#issuecomment-103475007
Received on Tuesday, 19 May 2015 12:53:38 UTC