Re: [webrtc-tests] Adding a basic no-media call that uses promises. (#1824)

Somehow your comments failed to attach to lines, which renders them a bit hard to parse.... where is step-naming different?
The "first" and "second" could be "caller" and "callee", but that's actually hard to distinguish visually. I inherited this from where I started working.
The reason for passing the offer/answer SDP through a global variable is that the implementation is allowed to modify the descriptions based on candidate generation, and I did not want that side effect to randomize what happened during this test (although it SHOULD have no effect).
My thought when adding the "atStep = negotiation completed" was that if something went wrong, I wanted to make sure the atStep did not show "setRemoteDescription first" after that step had completed. If debugging the script, one can look at the value :-)
Am going to submit a new update to take care of the whitespace error.


View on GitHub: https://github.com/w3c/web-platform-tests/pull/1824#issuecomment-103079647

Received on Monday, 18 May 2015 14:30:15 UTC