- From: Ms2ger <web-platform-tests-notifications@w3.org>
- Date: Wed, 23 Dec 2015 16:02:20 GMT
- To: public-web-platform-tests-notifications@w3.org
Review status: all files reviewed at latest revision, 9 unresolved discussions. --- *[touch-events/create-touch-touchlist.html, line 36 \[r3\]](https://reviewable.io:443/reviews/w3c/web-platform-tests/2299#-K6EZj9NDSXFp8MOzlLu:-K6EZj9NDSXFp8MOzlLv:163065205) ([raw file](https://github.com/w3c/web-platform-tests/blob/cfc9ade7ff7043ea24255bdc2908c3f7777542a4/touch-events/create-touch-touchlist.html#L36)):* Why did you add this? If `createTouch` doesn't exist, the following line will throw and cause a test failure. --- *[touch-events/touch-touchevent-constructor.html, line 19 \[r3\]](https://reviewable.io:443/reviews/w3c/web-platform-tests/2299#-K6EZUKjnb_nZRZMbhyg:-K6EZUKktNR7sIBW8_dq:940059113) ([raw file](https://github.com/w3c/web-platform-tests/blob/cfc9ade7ff7043ea24255bdc2908c3f7777542a4/touch-events/touch-touchevent-constructor.html#L19)):* No need for this. --- *[touch-events/touch-touchevent-constructor.html, line 28 \[r3\]](https://reviewable.io:443/reviews/w3c/web-platform-tests/2299#-K6EZ4KzZiVDXXyvfZ_F:-K6EZ4KzZiVDXXyvfZ_G:-221683987) ([raw file](https://github.com/w3c/web-platform-tests/blob/cfc9ade7ff7043ea24255bdc2908c3f7777542a4/touch-events/touch-touchevent-constructor.html#L28)):* There doesn't seem to be a reason to wait for the `load` event. Also remove the `setup`/`done` calls. --- *[touch-events/touch-touchevent-constructor.html, line 30 \[r3\]](https://reviewable.io:443/reviews/w3c/web-platform-tests/2299#-K6EYlK6Wqz6JVSxZs2U:-K6EYlK7ZksCOXjpXrhv:1467327424) ([raw file](https://github.com/w3c/web-platform-tests/blob/cfc9ade7ff7043ea24255bdc2908c3f7777542a4/touch-events/touch-touchevent-constructor.html#L30)):* Please move those `var`s to where they're used; they're not shared between tests (which would be bad practice). --- *[touch-events/touch-touchevent-constructor.html, line 65 \[r3\]](https://reviewable.io:443/reviews/w3c/web-platform-tests/2299#-K6EYyqM2tET7Us5giWc:-K6EYyqNAT4kanYF8THC:-911550786) ([raw file](https://github.com/w3c/web-platform-tests/blob/cfc9ade7ff7043ea24255bdc2908c3f7777542a4/touch-events/touch-touchevent-constructor.html#L65)):* No need for the assignments. --- *[touch-events/touch-touchevent-constructor.html, line 128 \[r3\]](https://reviewable.io:443/reviews/w3c/web-platform-tests/2299#-K6EZH9PJhDppFvnBEvr:-K6EZH9PJhDppFvnBEvs:306597936) ([raw file](https://github.com/w3c/web-platform-tests/blob/cfc9ade7ff7043ea24255bdc2908c3f7777542a4/touch-events/touch-touchevent-constructor.html#L128)):* No need to do this. --- *[touch-events/touch-touchevent-constructor.html, line 142 \[r3\]](https://reviewable.io:443/reviews/w3c/web-platform-tests/2299#-K6EZRIB0QfyA7M4rIBL:-K6EZRIB0QfyA7M4rIBM:-1236376120) ([raw file](https://github.com/w3c/web-platform-tests/blob/cfc9ade7ff7043ea24255bdc2908c3f7777542a4/touch-events/touch-touchevent-constructor.html#L142)):* Remove the styling --- *[touch-events/touch-touchevent-constructor.html, line 147 \[r3\]](https://reviewable.io:443/reviews/w3c/web-platform-tests/2299#-K6EZMW_fbGVCO_csbGk:-K6EZMW_fbGVCO_csbGl:-1396021968) ([raw file](https://github.com/w3c/web-platform-tests/blob/cfc9ade7ff7043ea24255bdc2908c3f7777542a4/touch-events/touch-touchevent-constructor.html#L147)):* Remove the text; it serves no purpose. --- *Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/w3c/web-platform-tests/2299)* <!-- Sent from Reviewable.io --> View on GitHub: https://github.com/w3c/web-platform-tests/pull/2299#issuecomment-166931494
Received on Wednesday, 23 December 2015 16:02:27 UTC