Re: [custom-elements-tests] second bunch of custom elements tests (#469) from Dominic Cooney on 2014-01-24 (public-web-platform-tests-notifications@w3.org from January 2014)

From: Dominic Cooney <web-platform-tests-notifications@w3.org>
Date: Fri, 24 Jan 2014 06:15:48 GMT
To: public-web-platform-tests-notifications@w3.org
Message-Id: <<web-platform-tests_issue_469_1390544148927@w3.org>>

Could we break this pull request up into two? One for the registry creation and passing, and one for the callbacks (or maybe even per-type of callback?)

I'm worried that we're not merging these tests fast enough. By making the reviews smaller we can start getting stuff committed. I also want you to take feedback from past reviews and apply them to your (existing and new) code. For example, I've noted using "should" to write clear assertion messages before, but it looks like that wasn't carried over into some parts of this file.

View on GitHub: https://github.com/w3c/web-platform-tests/pull/469#discussion_r9140825

Received on Friday, 24 January 2014 06:15:59 UTC