- From: Aleksei Semenov <web-platform-tests-notifications@w3.org>
- Date: Tue, 14 Jan 2014 10:51:35 GMT
- To: public-web-platform-tests-notifications@w3.org
I moved functions checkValidName, checkInvalidName, testCharCodeArray, testCharCodeRangesArray to the testcommon.js as you asked. But I am not satisfied with the result. In my opinion the check* functions should be in the test file, so it is easy to see what is checked. While iteration over various arrays could be hidden under single function. So moving checks to common shared functions will be not necessary. View on GitHub: https://github.com/w3c/web-platform-tests/pull/464#issuecomment-32254972
Received on Tuesday, 14 January 2014 10:51:41 UTC