Re: [custom-elements-tests][html-templates-tests] Submission/unipro custom elements (#464) from Dominic Cooney on 2014-01-14 (public-web-platform-tests-notifications@w3.org from January 2014)

From: Dominic Cooney <web-platform-tests-notifications@w3.org>
Date: Tue, 14 Jan 2014 04:31:41 GMT
To: public-web-platform-tests-notifications@w3.org
Message-Id: <<web-platform-tests_issue_464_1389673901896@w3.org>>

I'm worried this is buggy since on line 56 you go to lengths to call charCodeAt. I think I've commented on a similar bug before. Maybe you need to make these functions easier to use? (For example, you could make the helper function use typeof and handle either strings or numbers. It might be worth adding a sanity assertion that those strings are 1 char long.)

View on GitHub: https://github.com/w3c/web-platform-tests/pull/464#discussion_r8850426

Received on Tuesday, 14 January 2014 04:31:48 UTC