- From: Douglas Stockwell <web-platform-tests-notifications@w3.org>
- Date: Fri, 15 Aug 2014 04:21:15 GMT
- To: public-web-platform-tests-notifications@w3.org
I've finished a first pass of this change. Note, in my review, when there's a systematic issue I will usually comment about it only once but the change should be made to all occurrences, for example renaming `timedItem` to `animationNode`. Some additional questions: * Is there a JavaScript style guide for web-platform-tests? I noticed some inconsistencies around whether wrapping was done before or after binary operators. If there's not a style guide then I'm not terribly concerned. * Most of the utilities in testcommon are not used by the tests in this change, could we hold them back until they are necessary? View on GitHub: https://github.com/w3c/web-platform-tests/pull/1125#issuecomment-52273236
Received on Friday, 15 August 2014 04:21:21 UTC