- From: Amitay Dobo <web-platform-tests-notifications@w3.org>
- Date: Mon, 11 Nov 2013 15:55:44 GMT
- To: public-web-platform-tests-notifications@w3.org
Updated the pull request with a new commit. Addressed the following issues: 1. Wave file is generated using an included browser based utlitiy 2. Wave file and tests are all single channel (mono). 3. Removed some dead code. I didn't remove the test based on ScriptProcessor, as it exposes other failures in the implementations (compared to the OfflineAudioContext test). For example, in that test under Chrome, the scriptProcessor gets some additional data, not from the wave file, in its processaudio event input buffer. If you'd insist, of course I can remove that test, but I'm not sure why wouldn't we want to have as much tests as possible, especially when its demonstrated that those test results are not redundant. Thanks, Amitay View on GitHub: https://github.com/w3c/web-platform-tests/pull/396#issuecomment-28211315
Received on Monday, 11 November 2013 15:55:50 UTC