Re: [html] First batch of i18n tests: translate mode (#252) from jgraham on 2013-07-16 (public-web-platform-tests-notifications@w3.org from July 2013)

From: jgraham <web-platform-tests-notifications@w3.org>
Date: Tue, 16 Jul 2013 16:44:44 GMT
To: public-web-platform-tests-notifications@w3.org
Message-Id: <<web-platform-tests_issue_252_1373993084643@w3.org>>

This is bad style; you should put the code inside the test where possible. In this case

test(function() {
  assert_true(document.getElementById('box'));
  //Note this code isn't run if the assert fails
  box.style.backgroundColor = '#00FF00';
  box.style.color = 'white';
  box.innerHTML = 'Pass';
  box.style.height = '100px';
  box.style.width = '100px';
});

Similar comments presumably apply to other tests.

View on GitHub: https://github.com/w3c/web-platform-tests/pull/252#discussion_r5220744

Received on Tuesday, 16 July 2013 16:44:50 UTC