Re: [html-templates] Submission/unipro (#135)

Yuta-san, thank you for review. Let's take a look to the tests in html-templates/definitions folder. I fixed all of the issues for them, so please review them. If they are ok, I'll change the other tests in the same way. In more details changes are the following:

- reviewer matadata removed
- code was formatted to use 4-space indent
- single-letters variables were renamed to the more descriptive ones
- debugging and obsolete code was removed from testcommon.js

Only two items are still uncovered. 

The first one is the commit history. It'll be my next step. 

The second item is the third  (optional) argument of assert_*(). We always use the third argument and I believe there are at least two good reasons for that:
- if test fails this message helps to find assertion that failed. Otherwise tester would have to perform additional investigation to figure out what exact assertion fails
- this message also can help reader to better understand what the particular assertion checks

So we'd like to preserve this policy "Always add descriptive third argument to all assertions and make it unique if possible". 

View on GitHub: https://github.com/w3c/web-platform-tests/issues/135#issuecomment-20328376

Received on Tuesday, 2 July 2013 06:11:32 UTC