Looks good. The other methods on https://dvcs.w3.org/hg/webperf/raw-file/tip/specs/NavigationErrorLogging/Overview.html#extensions-performance-interface, are they synchronous? If not, is there any benefit to knowing when they complete? Also, minor nit: in the example, rather than var p = window.performance.getNavigationErrors(); p.then... I'd just do window.performance.getNavigationErrors().then...; OK Done. Please check: https://dvcs.w3.org/hg/webperf/raw-file/tip/specs/NavigationErrorLogging/Overview.html On Tue, Feb 11, 2014 at 2:24 AM, Jake Archibald <jakearchibald@chromium.org>wrote: > +1 > > Any async success (and optionally, failure) API should use promises. > > > On Tue, Feb 11, 2014 at 6:40 AM, Arvind Jain <arvind@google.com> wrote: > >> Does anyone else have an opinion? Should I go ahead and change >> getNavigationErrors to return a promise? >> >> https://dvcs.w3.org/hg/webperf/raw-file/tip/specs/NavigationErrorLogging/Overview.html >> >> >> On Tue, Feb 4, 2014 at 2:35 PM, ttuttle <ttuttle@chromium.org> wrote: >> >>> Hi, >>> >>> At Domenic Denicola's suggestion, can we have getNavigationErrors >>> return a promise instead of a callback? It should fail if the site >>> has never registered for error logging. >>> >>> Thanks, >>> >>> ttuttle >>> >> >> >
Received on Friday, 14 February 2014 18:16:05 UTC