Re: Bug in test_resource_reparenting.html

On Fri, Apr 4, 2014 at 3:40 PM, Philippe Le Hegaret <plh@w3.org> wrote:
> On Tue, 2014-04-01 at 19:32 -0400, Christian Biesinger wrote:
>> Hi there,
>>
>> I was looking at test_resource_reparenting.html and I think it is
>> incorrect. Per the HTML spec, image loading is triggered
>> asynchronously, see step 8 here:
>> http://www.whatwg.org/specs/web-apps/current-work/multipage/edits.html#update-the-image-data
>>
>> As a result, if an <img> element gets re-parented immediately, it
>> abort the initial async task, and queue a new async task for the new
>> document. So, only move_to_child should show up in the resource list
>> here.
>
> I believe you're correct. Since there is no cache involved, the fetching
> algorithm will always get aborted and no resource will get fetched.

Hmm, I'm not sure that's quite the right description - what will
actually happen is that move_to_child will get loaded in the child
document, and move_to_parent will get loaded in the parent document,
right?

Since the test expects move_to_parent to be loaded in the child, it fails.

>> Incidentally, I can't find a repository that contains that test, I can
>> only find an open pull request:
>> https://github.com/w3c/web-platform-tests/pull/402/commits
>> The webperf repository doesn't seem to have the test anymore?
>
> It got moved to github now indeed and the tests are awaiting corrections
> and reviews:
> https://github.com/w3c/web-platform-tests/issues?labels=wg-webperf&state=open

Thanks for working on this.

> I added
> https://dvcs.w3.org/hg/webperf/file/8de44381205b/tests/SEE_GITHUB_INSTEAD.txt
> in the hope of making it clearer

Thanks! That seems very helpful.

-christian

Received on Friday, 4 April 2014 20:39:01 UTC