Re: [web-nfc] Fix #592: allow multiple readers but no multiple scans on any reader (#611)

@beaufortfrancois 

> has_pending_scan_request_ check is only for when the ndef reader didn't settle yet

Do you refer to this? https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/modules/nfc/ndef_reader.cc;drc=aca54053714d442febdd5f87a26c4055e20bd632;l=187 
(it's another question what is the relation with the similarly named NDEFReader::HasPendingActivity()...)

But then see that the condition is bound to the existence of the reader _after_ it checked was there a pending scan request. Also the design doc states there is only one scan in a reader active at any time.
https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/modules/nfc/ndef_reader.cc;drc=aca54053714d442febdd5f87a26c4055e20bd632;l=135 

Could you point out which algorithmic steps are in conflict with the implementation?



-- 
GitHub Notification of comment by zolkis
Please view or discuss this issue at https://github.com/w3c/web-nfc/pull/611#issuecomment-749793115 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Tuesday, 22 December 2020 21:51:40 UTC