- From: Nik Markovic via GitHub <sysbot+gh@w3.org>
- Date: Thu, 28 Jul 2016 19:03:41 +0000
- To: public-web-bluetooth-log@w3.org
>> 1) BluetoothLEScanFilterInit.manufacturerData, shouldn't this be renamed into "manufacturerId"? Similarly serviceData to "serviceDataUUID". >My thought with those fields was that we could later extend them to whole objects with all the complexity of https://developer.android.com/reference/android/bluetooth/le/ScanFilter.Builder.html, so I wanted to use the same names as the AD field. That said, I can see some sense in using a different name for the shorthand. While I mull it over, :+1: this comment to prefer manufacturerId and serviceDataUUID or :-1: this comment to prefer manufacturerData and serviceData? I can definitely see the value in being able to specify a mask in manufacturer data. If you are planning on supporting that in the future. Maybe it's better that we define the .manufacturerData filter to be a structure that contains (at this time only) manufacturer ID? If you don't opt for this, then it may be better to still keep the manufacturerId as the name of the field, then you can do a conversion or "deprecated detection" once you have a new version of the API. -- GitHub Notification of comment by nik-markovic Please view or discuss this issue at https://github.com/WebBluetoothCG/web-bluetooth/pull/239#issuecomment-235993220 using your GitHub account
Received on Thursday, 28 July 2016 19:03:48 UTC