W3C home > Mailing lists > Public > public-web-bluetooth-log@w3.org > April 2015

Re: [web-bluetooth] Switch to ReSpec's contiguous IDL mode.

From: Vincent Scheib via GitHub <sysbot+gh@w3.org>
Date: Wed, 15 Apr 2015 00:15:36 +0000
To: public-web-bluetooth-log@w3.org
Message-ID: <issue_comment.created-93120096-1429056934-sysbot+gh@w3.org>







<sup>**[index.html, line 323 
\[r1\]](https://reviewable.io:443/reviews/webbluetoothcg/web-bluetooth/102#-JmuAI9RYJZizOk6E8fe)**
 ([raw 
file](https://github.com/webbluetoothcg/web-bluetooth/blob/56d3238dea4fcfe4475af1e45c7ad7b1ba2a097b/index.html#L323)):</sup>
Unsure if you'd like to do content editing as well with this refactor.
 If so, probably pull the "matches a filter" definition up to this 
section. Or, at least link 'match' here with `<a title="matches a 
filter">match</a>`

---

<sup>**[index.html, line 327 
\[r1\]](https://reviewable.io:443/reviews/webbluetoothcg/web-bluetooth/102#-JmuGB0Fw8f05-mcq2dB)**
 ([raw 
file](https://github.com/webbluetoothcg/web-bluetooth/blob/56d3238dea4fcfe4475af1e45c7ad7b1ba2a097b/index.html#L327)):</sup>
Drop the `In `. There's lack of consistency with the dictionaries 
BluetoothScanFilter and RequestDeviceOptions, and I miss the clarity 
of the [old 
version](http://webbluetoothcg.github.io/web-bluetooth/#widl-BluetoothScanFilter-services)
 in sections with headers. They are small interfaces, though, so the 
single lines are fine. I prefer the directness of 
`BluetoothScanFilter.services holds ...`

---

<sup>**[index.html, line 907 
\[r1\]](https://reviewable.io:443/reviews/webbluetoothcg/web-bluetooth/102#-JmuOJXiqd8U1eDK6O1r)**
 ([raw 
file](https://github.com/webbluetoothcg/web-bluetooth/blob/56d3238dea4fcfe4475af1e45c7ad7b1ba2a097b/index.html#L907)):</sup>
A note here seems odd, these are the attribute definitions and seem 
appropriate to be in 'normal' spec prose. Perhaps sectioned off with a
 header.

---

<sup>**[index.html, line 981 
\[r1\]](https://reviewable.io:443/reviews/webbluetoothcg/web-bluetooth/102#-JmuQ1zXyPDpiq96G0Hx)**
 ([raw 
file](https://github.com/webbluetoothcg/web-bluetooth/blob/56d3238dea4fcfe4475af1e45c7ad7b1ba2a097b/index.html#L981)):</sup>
Consider leading with the term being defined. `connectGATT() is used 
to obtain a  BluetoothGATTRemoteServer from a device. The UA MUST 
return ...`

---


---

Comments from the [review on 
Reviewable.io](https://reviewable.io:443/reviews/webbluetoothcg/web-bluetooth/102)
<!-- Sent from Reviewable.io -->


-- 
GitHub Notif of comment by scheib
See 
https://github.com/WebBluetoothCG/web-bluetooth/pull/102#issuecomment-93120096
Received on Wednesday, 15 April 2015 00:15:47 UTC

This archive was generated by hypermail 2.3.1 : Wednesday, 15 April 2015 00:15:47 UTC