[webvtt] About reviewing changes

I thought this might be good to share with the whole group. We'll learn as  
we go and I think we don't really need much of a formal process, but I'd  
like to point out that if someone is interested in a particular bug or  
issue or pull request, please add a comment saying you wish to review.  
That way I can wait with merging where necessary without slowing down  
everything else. :-)


------- Forwarded message -------
From: "Simon Pieters" <simonp@opera.com>
To: "Andreas Tai" <tai@irt.de>
Cc:
Subject: Re: Fwd: Re: [webvtt] Fix #260: Add a non-CSS UA conformance  
class (#261)
Date: Wed, 18 Nov 2015 18:18:32 +0100

On Wed, 18 Nov 2015 16:50:59 +0100, Andreas Tai <tai@irt.de> wrote:

> Hi Simon,
>
> Apologies for commenting on it after the merge. I saw the pull request
> before but had no time to comment. What review time do you give normally
> your pull requests before you merge it?

Normally as soon as someone has reviewed, I merge. If I believe something
can be controversial I will wait a few days. In this case it looks like I
waited 3 days. If you wish to review something but don't have time to do
so yet, just add a comment saying you wish to review. Also, if something
was merged but you disagree with the change, you can ask for a revert and
reopen the relevant issue.

Does that sound reasonable?

cheers


-- 
Simon Pieters
Opera Software

Received on Thursday, 19 November 2015 10:11:36 UTC