RE: something broken in wpt run

Two things:


  1.  This was a bug in Windows. Which shocks me. I updated to last night's build and with NO OTHER CHANGES it started working again.
  2.  I am deeply grateful for the response from this alias to my questions. Not only on this main thread, but I had multiple people ping me offline to help as well. This community is awesome, and I really appreciate it.

I'll comment on the issue in Github now.


From: John Jansen [mailto:John.Jansen@microsoft.com]
Sent: Tuesday, January 16, 2018 5:05 PM
To: Geoffrey Sneddon <me@gsnedders.com>; David Burns <dburns@mozilla.com>
Cc: Philip Jägenstedt <foolip@google.com>; public-test-infra@w3.org
Subject: RE: something broken in wpt run

I'm going to keep playing with this, but that specific change does not seem to be the culprit. I checked out several different commits in sequence (and I verified that the .py file from 9058 was reverted), but I still get the failure.

I'm going to end up going backward through commits until I get it...

NOTE: I'm not using Python 3, I'm on 2.7.14

Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows 10

________________________________
From: Geoffrey Sneddon <me@gsnedders.com<mailto:me@gsnedders.com>>
Sent: Tuesday, January 16, 2018 2:16:43 PM
To: David Burns
Cc: Philip Jägenstedt; John Jansen; public-test-infra@w3.org<mailto:public-test-infra@w3.org>
Subject: Re: something broken in wpt run

Yeah, that'd be my guess.
I've filed https://github.com/w3c/web-platform-tests/issues/9058 for this; I'll take a look tomorrow.
/g

On Tue, Jan 16, 2018 at 9:22 PM, David Burns <dburns@mozilla.com<mailto:dburns@mozilla.com>> wrote:
>From a quick look it could be https://github.com/w3c/web-platform-tests/commit/a1de23740cb079b71517dff563b919416198e6ca that broke it so could you update to the revision before that and see if that works.

David

On 16 January 2018 at 21:08, Philip Jägenstedt <foolip@google.com<mailto:foolip@google.com>> wrote:
OK, so on that other machine, you were on b7034cfdba which is from Jan 5, does that sound right? If you check out that commit, does it work?

Once you have a known good and bad revision, can you try git bisect to get to the culprit?

On Tue, Jan 16, 2018 at 9:58 PM John Jansen <John.Jansen@microsoft.com<mailto:John.Jansen@microsoft.com>> wrote:
On a different machine, I just did a fetch && merge and now get the same error on there.

Does this make sense? I'm not great at git yet:

git reflog
9b10724c89 (HEAD -> master, origin/master, origin/HEAD) HEAD@{0}: merge origin/master: Fast-forward
b7034cfdba (tag: merge_pr_8926) HEAD@{1}: clone: from https://github.com/w3c/web-platform-tests.git

From: John Jansen
Sent: Tuesday, January 16, 2018 12:54 PM
To: Philip Jägenstedt <foolip@google.com<mailto:foolip@google.com>>; me@gsnedders.com<mailto:me@gsnedders.com>
Cc: public-test-infra@w3.org<mailto:public-test-infra@w3.org>
Subject: RE: something broken in wpt run

Thanks for the quick responses.

I nuked the repo from orbit. Deleted the directory and did a new clone; unfortunately, that means I cannot see what commit I was on that worked.
I do have the _venv folder, but the only thing in there is a Lib directory

From: Philip Jägenstedt [mailto:foolip@google.com]
Sent: Tuesday, January 16, 2018 12:48 PM
To: John Jansen <John.Jansen@microsoft.com<mailto:John.Jansen@microsoft.com>>; me@gsnedders.com<mailto:me@gsnedders.com>
Cc: public-test-infra@w3.org<mailto:public-test-infra@w3.org>
Subject: Re: something broken in wpt run

Hi John, can you tell from git reflog what commit you were on when you know this was working?

+Geoffrey Sneddon<mailto:me@gsnedders.com>, you've made two recent changes to virtualenv.py, does the error look like it could be caused by those?

On Tue, Jan 16, 2018 at 9:10 PM John Jansen <John.Jansen@microsoft.com<mailto:John.Jansen@microsoft.com>> wrote:
I just did a brand-new clone of web-platform-tests, and now when I try to run the tests:

Python wpt run edge weddriver

I get an error:

Traceback (most recent call last):
  File "wpt", line 5, in <module>
    wpt.main()
  File "C:\users\johnjan\documents\github\web-platform-tests\tools\wpt\wpt.py", line 111, in main
    venv = setup_virtualenv(main_args.venv, props)
  File "C:\users\johnjan\documents\github\web-platform-tests\tools\wpt\wpt.py", line 84, in setup_virtualenv
    venv.start()
  File "C:\users\johnjan\documents\github\web-platform-tests\tools\wpt\virtualenv.py", line 47, in start
    self.activate()
  File "C:\users\johnjan\documents\github\web-platform-tests\tools\wpt\virtualenv.py", line 42, in activate
    execfile(path, {"__file__": path})
IOError: [Errno 2] No such file or directory: 'C:\\users\\johnjan\\documents\\github\\web-platform-tests\\_venv\\Scripts\\activate_this.py'

Is there some new step I need to take to force the Scripts directory to get created?

This worked last night before I got the changes from this weekend.

Can you help?