On Fri, 17 Feb 2017 03:21:34 +0100, Benjamin Schaaf <ben.schaaf@gmail.com> wrote: > Yea, I agree, having both (help and a JSON file) would be good. The > help links are good documentation and can help analyzing test coverage > and the JSON file can be used for classifying tests. > > Maybe instead of just a js file for setting expected margins we can > have a JSON file that matches user agent strings to margins. This > would make it easy to run the tests on travis (since it runs the same > code for ff and chrome afaik). Hmm. Yeah, maybe. As much as I hate the idea of UA sniffing in tests, I think there aren't any great options. Unless everyone can agree on a particular margin they want to use, and we just require that much margin in the specification... -- Simon Pieters Opera SoftwareReceived on Friday, 17 February 2017 11:52:47 UTC
This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 17:34:13 UTC