W3C home > Mailing lists > Public > public-test-infra@w3.org > April to June 2017

Re: Web Platform Tests Pull Request Commenting

From: Tobie Langel <tobie@codespeaks.com>
Date: Tue, 09 May 2017 14:45:03 +0200
Message-Id: <1494333903.35434.970694669.13155C8F@webmail.messagingengine.com>
To: public-test-infra@w3.org
Thanks for the write-up Bob.

I'm glad there are now resources to get going on this.

Couple of high-level comments:

1. Would be nice to see this as a node.js project rather than a python
one. This is a common request from developers and there is no reason to
build this in python (it's not going to run on vendor CI
2. This proposal seems to conflate handling the to many bot comments
issue with a desire to move everything to a single code base. This
should be spelled out and discussed.
3. This proposal doesn't seem to address important questions such as how
to handle merges in dirs where no one has commit access.
4. This proposal seems to ignore the cost of changing the existing bots
to handle this new infra. While this is rather easy to do for comments,
it's not going to be that simple for the rest of what wpt-pr-bot (aka
ganesh) does. I'm not willing to invest the time to do this or to deal
with the consequences of it. So this will need to be sorted out.


Received on Tuesday, 9 May 2017 12:45:30 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 17:34:13 UTC