Re: Approving new reviewers?

On 25/01/15 10:29, Andreas Tolfsen wrote:
> On 25 Jan 2015, at 00:16, James Graham <> wrote:
>> On 24/01/15 23:23, Brad Hill wrote:
>>> Would it be possible to add Yan Zhu and Devdatta Akhawe as reviewers
>>> for the WebAppSec portions of web-platform-tests? (currently
>>> /subresource-integrity,  /content-security-policy and /cors)
>> This doesn't need any sort of formal approval to do reviews. They just
>> need to set up critic filters for the given directories following the
>> instructions at [1].
> This will notify you when new reviews are created that contain changes matching the filters you set up.
> However you might need to explicitly add yourself to existing reviews by clicking the “Add Reviewer” button, as a new filter won’t retrospectively assign you to any pre-exsting reviews.

That isn't true (it used to be, but was fixed in critic).

Received on Sunday, 25 January 2015 12:21:54 UTC