- From: Zhang, Zhiqiang <zhiqiang.zhang@intel.com>
- Date: Tue, 16 Dec 2014 02:15:42 +0000
- To: Brad Hill <hillbrad@gmail.com>, public-test-infra <public-test-infra@w3.org>
> From: Brad Hill [mailto:hillbrad@gmail.com] > Sent: Tuesday, December 16, 2014 09:49 > As a reviewer of a test, is there any way in which I can propose changes to a PR beyond raising an issue and waiting for the original author to fix it? Good question. I think we shall make some improvement on the review process about this, like a review is able to land his/her fixing to an existing PR from others including that PR :) > Is there any way to do this? Does bob have to add me as a collaborator on his fork? Seems so if you want to push code to bob's repository. I once did this by making pull requests to that forked repository at https://github.com/dontcallmedom/web-platform-tests/pulls?q=is%3Apr+is%3Aclosed ... but this involves forking a forked repository and needs the original author to merge these pull requests. I also noticed that Ms2ger reworked some pull requests at https://github.com/w3c/web-platform-tests/pull/583 for #289 https://github.com/w3c/web-platform-tests/pull/563 for #291 ... this method looks better, though it still involves other reviewers, because the Critic review then may refuse Ms2ger to review his fixing commits. Thanks, Zhiqiang
Received on Tuesday, 16 December 2014 02:16:14 UTC