review comments on struct-dom-16-f.svg from Cameron McCormack on 2010-10-22 (public-svg-wg@w3.org from October to December 2010)

From: Cameron McCormack <cam@mcc.id.au>
Date: Fri, 22 Oct 2010 16:32:11 +1300
To: public-svg-wg@w3.org
Message-ID: <20101022033210.GG23864@wok.mcc.id.au>

I’m mostly happy with this test.  I would like the sub-test for
createSVGTransform() to also check that the .matrix and .angle
properties are appropriately initialised, though.

Testing createSVGTransformForMatrix() isn’t really testing for
explicitly defined default values as the test description says, but I
don’t really mind that it’s in this test.  Please check the .matrix and
.angle values of the resulting SVGTransform for this sub-test, too.

Note that the sub-test for createSVGMatrix() checks .c twice; one can be
removed.

-- 
Cameron McCormack ≝ http://mcc.id.au/

Received on Friday, 22 October 2010 03:32:49 UTC