[data-shapes] Process: Merging PRs (#320)

PapoutsoglouE has just created a new issue for https://github.com/w3c/data-shapes:

== Process: Merging PRs ==
At today's WG meeting, one of the topics discussed was the approach to merging PRs. Right now, only one approval is required before merging.  
In some cases, such as editorial changes, this may be fine. However, many PRs would benefit from a broader review. Due to time constraints, this sometimes leads to PRs being merged before more participants have had a chance to review them.

Given the discussion we had, I would take some time to think about this, but here are possible approaches, in my personal order of preference:
1. Decide to not merge non-editorial issues for at least 3 (working) days to give people the opportunity to review
    * or explicitly state that they need more time
2. Use PR templates to keep track of status (incl. checklist)
3. Require that PRs are not merged until they have been discussed at the next WG meeting.
4. Use tools like `CODEOWNERS` (see #313) - imho this would help a bit, but not with the time aspect

I would like to not spent much more meeting time on this, and ideally to have a decision ready to announce at the next meeting. Until then, feedback and suggestions are welcome!



Please view or discuss this issue at https://github.com/w3c/data-shapes/issues/320 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Monday, 10 March 2025 22:23:05 UTC