[presentation-api] Pull Request: typo remove method

• From: You Kinjoh via GitHub <sysbot+gh@w3.org>
• Date: Wed, 14 Dec 2022 02:37:31 +0000
• To: public-secondscreen@w3.org
• Message-ID: <pull_request.opened-1164140836-1670985449-sysbot+gh@w3.org>

youkinjoh has just submitted a new pull request for https://github.com/w3c/presentation-api:

== typo remove method ==
This logic is remove method when reconnect.

Target method name is `onclose` .

```js
    connection.onclose = _ => {
      connection = null;
      showDisconnectedUI();
    };
```

But, this logic remove `onclosed` method.
```js
    // Disconnect from existing presentation, if not attempting to reconnect
    if (connection && connection != newConnection && connection.state != 'closed') {
      connection.onclosed = undefined;
      connection.close();
    }
```

See https://github.com/w3c/presentation-api/pull/508


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Wednesday, 14 December 2022 02:37:33 UTC