W3C home > Mailing lists > Public > public-secondscreen@w3.org > November 2016

Re: [presentation-api] Move mixed content check to PresentationRequest ctor.

From: François Daoust via GitHub <sysbot+gh@w3.org>
Date: Tue, 29 Nov 2016 08:02:16 +0000
To: public-secondscreen@w3.org
Message-ID: <issue_comment.created-263502084-1480406534-sysbot+gh@w3.org>
That looks good to me.

About the sandboxing flag, cannot sandboxing conditions change over 
time? For instance, the `sandbox` attribute of an `iframe` element may
 be removed at any time, which resets the sandboxing flag set:

> When an iframe element’s sandbox attribute is removed while it has a
 nested browsing context, the user agent must empty the iframe 
element’s nested browsing context’s iframe sandboxing flag set as the 
output.
> 
http://www.w3.org/TR/html51/semantics-embedded-content.html#element-attrdef-iframe-sandbox

Now, one could argue that once you have an `PresentationRequest` 
instance, you should be able to use it, even if sandboxing conditions 
change (and I don't see any good reason for an app to change the value
 of the `sandbox` attribute on the fly).

The check could also be done in the constructor **and** in start(), 
reconnect(), etc.



-- 
GitHub Notification of comment by tidoust
Please view or discuss this issue at 
https://github.com/w3c/presentation-api/pull/377#issuecomment-263502084
 using your GitHub account
Received on Tuesday, 29 November 2016 08:02:22 UTC

This archive was generated by hypermail 2.3.1 : Tuesday, 29 November 2016 08:02:23 UTC