W3C home > Mailing lists > Public > public-secondscreen@w3.org > April 2015

[presentation-api] Pull Request: Renamed postMessage() to send() to align with WebRTC DataChannel

From: Anton Vayvod via GitHub <sysbot+gh@w3.org>
Date: Thu, 02 Apr 2015 13:14:34 +0000
To: public-secondscreen@w3.org
Message-ID: <pull_request.opened-32510009-1427980472-sysbot+gh@w3.org>
avayvod has just submitted a new pull request for 
https://github.com/w3c/presentation-api:

== Renamed postMessage() to send() to align with WebRTC DataChannel ==
While trying to land the first CL implementing postMessage in Blink 
the reviewer noticed that postMessage() is already used in numerous 
other APIs and has a different signature. 
PresentationSession.postMessage() is a copy of WebRTC DataChannel 
send() and Mark Foltz's proposal also named the method send() (see 
https://github.com/w3c/presentation-api/issues/46).

Mozilla has implemented it as a send() too 
(https://bugzilla.mozilla.org/attachment.cgi?id=8527264&action=diff#a/dom/webidl/PresentationSocketChannel.webidl_sec1).

The Blink CL with the context is here: 
https://codereview.chromium.org/1002293005

P.S. Also accidentally removed some trailing whitespace it seems.

See https://github.com/w3c/presentation-api/pull/72
Received on Thursday, 2 April 2015 13:14:43 UTC

This archive was generated by hypermail 2.3.1 : Thursday, 2 April 2015 13:14:44 UTC