W3C home > Mailing lists > Public > public-schemaorg@w3.org > April 2016

Re: PhysicalActivity, ExercisePlan

From: Dan Brickley <danbri@google.com>
Date: Thu, 21 Apr 2016 17:00:39 +0100
Message-ID: <CAK-qy=6b6cxOdDUxABEB2_48GWqbbO4z1vVUemhO1iZwkSVpfw@mail.gmail.com>
To: Marc Twagirumukiza <marc.twagirumukiza@agfa.com>, "schema.org Mailing List" <public-schemaorg@w3.org>
Update: Marc and I met in Skype and went over the details here, as
well as fixing some other typos that came up in release candidate
review.

Cause: our type subClassOf hierarchy included terms deep in the tree
whose supertypes were only introduced in the health-lifesci extension:

[core]Thing > [health-lifesci]MedicalEntity >[health-lifesci]
MedicalTherapy >[health-lifesci] LifestyleModification >
[core]PhysicalActivity >[core] ExercisePlan

The immediate outcome is that we agreed it makes sense to move
PhysicalActivity and ExercisePlan into health-lifesci. They are from
the same original medical vocab collaboration as the rest of the
terms, and are written in the same tone (healthcare oriented). We also
moved to the extension the 'exercisePlan' property (a subproperty of
'instrument') which links ExercisePlan to ExerciseAction. This was
done for the same reason: extension terms can be defined by reference
to core terms (subClassOf, domainIncludes etc) but it does not work
well in the opposite direction.

I've implemented this already
(https://github.com/schemaorg/schemaorg/commit/950a7bff8261f954312aea52ee865b556891eaa3)
and pushed it to the webschemas.org site for review.
http://health-lifesci.webschemas.org/PhysicalActivity and
http://health-lifesci.webschemas.org/ExercisePlan look much better
(previously PhysicalActivity was floating around as a type with no
obvious supertype).

So --- I think we're back on track. Apologies for not anticipating
this. We'll have to get some unit tests in place to check for such
situations since extension schemas are often intimately cross-linked
with the core. To capture the broader need for guiding documentation +
QA unit tests on this, I've filed
https://github.com/schemaorg/schemaorg/issues/1117

Thanks Marc for helping figure this out,

cheers,

Dan

On 21 April 2016 at 15:51, Dan Brickley <danbri@google.com> wrote:
> Looking at these:
>
> Currently in v2.2 on schema.org they are both in the flat core. In the
> v3.0 release candidate we have them still in the core.
>
> However we have somehow broken PhysicalActivity. I'd like to find a
> simple fix for this release.
>
> Compare (where schema.org has v2.2, webschemas has candidate v3.0):
>
> * http://schema.org/ExercisePlan
> * http://webschemas.org/ExercisePlan
> * http://schema.org/PhysicalActivity
> * http://webschemas.org/PhysicalActivity
>
> Here (below) are the definitions (in triples) currently in
> data/schema.org i.e. the core.
>
> They do look to me (from the descriptions) as if they were part of the
> big collection of medical docs i.e.
> http://schema.org/docs/meddocs.html. Did you discuss including in core
> vs health-lifesci extension?
>
> It seems that the definitions in repo currently have lost this:
>
> Thing > MedicalEntity > MedicalTherapy > LifestyleModification >
> PhysicalActivity
>
> ... it seems that LifestyleModification moved to the extension but
> PhysicalActivity did not. It might be easiest to have them all in the
> extension. Thoughts?
>
> cheers,
>
> Dan
>
>
>
>
>
> 15:35 $ ../scripts/rdfa2nt schema.rdfa | grep ExercisePlan
>
>
> <http://schema.org/workload> <http://schema.org/domainIncludes>
> <http://schema.org/ExercisePlan> .
>
> <http://schema.org/repetitions> <http://schema.org/domainIncludes>
> <http://schema.org/ExercisePlan> .
>
> <http://schema.org/activityFrequency>
> <http://schema.org/domainIncludes> <http://schema.org/ExercisePlan> .
>
> <http://schema.org/exerciseType> <http://schema.org/domainIncludes>
> <http://schema.org/ExercisePlan> .
>
> <http://schema.org/ExercisePlan>
> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type>
> <http://www.w3.org/2000/01/rdf-schema#Class> .
>
> <http://schema.org/additionalVariable>
> <http://schema.org/domainIncludes> <http://schema.org/ExercisePlan> .
>
> <http://schema.org/intensity> <http://schema.org/domainIncludes>
> <http://schema.org/ExercisePlan> .
>
> <http://schema.org/ExercisePlan>
> <http://www.w3.org/2000/01/rdf-schema#comment> "Fitness-related
> activity designed for a specific health-related purpose, including
> defined exercise routines as well as activity prescribed by a
> clinician." .
>
> <http://schema.org/ExercisePlan>
> <http://www.w3.org/2000/01/rdf-schema#subClassOf>
> <http://schema.org/PhysicalActivity> .
>
> <http://schema.org/exercisePlan> <http://schema.org/rangeIncludes>
> <http://schema.org/ExercisePlan> .
>
> <http://schema.org/activityDuration>
> <http://schema.org/domainIncludes> <http://schema.org/ExercisePlan> .
>
> <http://schema.org/restPeriods> <http://schema.org/domainIncludes>
> <http://schema.org/ExercisePlan> .
>
> <http://schema.org/ExercisePlan>
> <http://www.w3.org/2000/01/rdf-schema#subClassOf>
> <http://schema.org/CreativeWork> .
>
> <http://schema.org/ExercisePlan>
> <http://www.w3.org/2000/01/rdf-schema#label> "ExercisePlan" .
>
>
>
>
> 15:38 $ ../scripts/rdfa2nt schema.rdfa | grep PhysicalActivity
>
> <http://schema.org/LeisureTimeActivity>
> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type>
> <http://schema.org/PhysicalActivityCategory> .
>
> <http://schema.org/category> <http://schema.org/rangeIncludes>
> <http://schema.org/PhysicalActivityCategory> .
>
> <http://schema.org/StrengthTraining>
> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type>
> <http://schema.org/PhysicalActivityCategory> .
>
> <http://schema.org/PhysicalActivity>
> <http://www.w3.org/2000/01/rdf-schema#label> "PhysicalActivity" .
>
> <http://schema.org/PhysicalActivityCategory>
> <http://www.w3.org/2000/01/rdf-schema#label>
> "PhysicalActivityCategory" .
>
> <http://schema.org/PhysicalActivityCategory>
> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type>
> <http://www.w3.org/2000/01/rdf-schema#Class> .
>
> <http://schema.org/PhysicalActivity>
> <http://www.w3.org/2000/01/rdf-schema#comment> "Any bodily activity
> that enhances or maintains physical fitness and overall health and
> wellness. Includes activity that is part of daily living and routine,
> structured exercise, and exercise prescribed as part of a medical
> treatment or recovery plan." .
>
> <http://schema.org/PhysicalActivity>
> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type>
> <http://www.w3.org/2000/01/rdf-schema#Class> .
>
> <http://schema.org/category> <http://schema.org/domainIncludes>
> <http://schema.org/PhysicalActivity> .
>
> <http://schema.org/PhysicalActivityCategory>
> <http://www.w3.org/2000/01/rdf-schema#subClassOf>
> <http://schema.org/Enumeration> .
>
> <http://schema.org/Balance>
> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type>
> <http://schema.org/PhysicalActivityCategory> .
>
> <http://schema.org/ExercisePlan>
> <http://www.w3.org/2000/01/rdf-schema#subClassOf>
> <http://schema.org/PhysicalActivity> .
>
> <http://schema.org/AnaerobicActivity>
> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type>
> <http://schema.org/PhysicalActivityCategory> .
>
> <http://schema.org/PhysicalActivityCategory>
> <http://www.w3.org/2000/01/rdf-schema#comment> "Categories of physical
> activity, organized by physiologic classification." .
>
> <http://schema.org/AerobicActivity>
> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type>
> <http://schema.org/PhysicalActivityCategory> .
>
> <http://schema.org/OccupationalActivity>
> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type>
> <http://schema.org/PhysicalActivityCategory> .
>
> <http://schema.org/Flexibility>
> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type>
> <http://schema.org/PhysicalActivityCategory> .
Received on Thursday, 21 April 2016 16:01:09 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 17:12:24 UTC