Re: Editorial bugs?

Hi Souri,

On Oct 31, 2010, at 19:31 , Souripriya Das wrote:

> Ivan,
> 
> Thanks for your comments. Please see my reply inline.
> Also, please note that we will make your suggested changes as part of some other changes we are making to the document to make it easier to understand.
> 
> Thanks,
> - Souri.
> 
> On 10/31/2010 9:04 AM, Ivan Herman wrote:
>> Guys,
>> 
>> I am just in the process of familiarizing myself with r2rml, so I may have misunderstood things, so bear with me. But these might be genuine problems:
>> 
>> In 3.3.1.1, shouldn't there be '(' and ')' characters surrounding 'Department' || depno ? 
>>   
>> 
> The '(' and ')' are not necessary, but could be added.

Ah. That come from my ignorance of the SQL syntax. Still, I believe adding the parentheses is a good idea, to be consistent within the document itself.

[snip]

>> 
>> Looking at the A.2.2 example, there is a rr:foreignKeyMap part that does not seem to refer to any specific table in the example, nor does it seem to affect the resulting graphs. (Not being a RDB person I must admit I had problems understanding this part of the spec anyway, an example would be welcome...)
>> 
>>   
>> 
> That was an error.
> rr:parentTriplesMap xyz:dept;
> 
> should have been
> rr:parentTriplesMap <#TriplesMap1>;
> This error is present in two other places. These have been corrected in a recent version of Editors' draft.


Aha. That makes it a little bit more understandable. However... isn't it true that, somehow, extra triples generated by this foreign key should also appear in the A.2.2 example? I am not 100% what they should be. Is it something like

<xyz.com/emp/7369> emp:c_ref_deptno _:Department10 .

Plus all the triples generated by the example in A.2.1.?

This is very unclear (for my taste) in the description of the foreign key stuff, which only speaks about the RDF property but does not speak about the object of the generated triple. The triple I have here is just, well, something that makes sense to me...

B.t.w., it would be nice if the generated graphs appeared as a graph figure. It would make it more understandable to me...

Thanks!

Ivan


>> I hope this helps
>> 
>> Thanks!
>> 
>> Ivan
>> 
>> ----
>> Ivan Herman, W3C Semantic Web Activity Lead
>> Home: 
>> http://www.w3.org/People/Ivan/
>> 
>> mobile: +31-641044153
>> PGP Key: 
>> http://www.ivan-herman.net/pgpkey.html
>> 
>> FOAF: 
>> http://www.ivan-herman.net/foaf.rdf
>> 
>> 
>> 
>> 
>> 
>> 
>>   
>> 
> 


----
Ivan Herman, W3C Semantic Web Activity Lead
Home: http://www.w3.org/People/Ivan/
mobile: +31-641044153
PGP Key: http://www.ivan-herman.net/pgpkey.html
FOAF: http://www.ivan-herman.net/foaf.rdf