W3C home > Mailing lists > Public > public-publ-wg@w3.org > August 2017

Re: [Tooling] a new feature installed on our HTML/respec oriented repositories

From: Charles LaPierre <charlesl@benetech.org>
Date: Mon, 21 Aug 2017 15:57:36 +0000
To: "Siegman, Tzviya - Hoboken" <tsiegman@wiley.com>
CC: Ivan Herman <ivan@w3.org>, W3C Publishing Working Group <public-publ-wg@w3.org>, Tobie Langel <tobie@codespeaks.com>
Message-ID: <107958E4-1DCF-413F-AC1E-301D63574EF0@benetech.org>
I also really like this new feature and it is somewhat accessible with keyboard navigation (with j and k) , but unfortunately on a Mac with Voice Over using (Safari, FireFox, or Chrome) as you move from change to change nothing is spoken to the user.  I will be curious if this is the same behavior using JAWS or NVDA on a PC.
Definitely a step in the right direction and will be wonderful if we can get it to automatically speak the changes and if the change was an addition, change or deletion as I assume that is what the different colors Red, Green, and Yellow are.  Not sure how well those colors are distinguishable in different forms of color blindness.


Charles LaPierre
Technical Lead, DIAGRAM and Born Accessible
E-mail: charlesl@benetech.org<mailto:charlesl@benetech.org>
Twitter: @CLaPierreA11Y
Skype: charles_lapierre
Phone: 650-600-3301

On Aug 21, 2017, at 7:10 AM, Siegman, Tzviya - Hoboken <tsiegman@wiley.com<mailto:tsiegman@wiley.com>> wrote:

This is great! Thanks, Tobie

Tzviya Siegman
Information Standards Lead

-----Original Message-----
From: Ivan Herman [mailto:ivan@w3.org]
Sent: Monday, August 21, 2017 3:21 AM
To: W3C Publishing Working Group <public-publ-wg@w3.org<mailto:public-publ-wg@w3.org>>
Cc: Tobie Langel <tobie@codespeaks.com<mailto:tobie@codespeaks.com>>
Subject: [Tooling] a new feature installed on our HTML/respec oriented repositories

One of the problems with the Pull Request mechanism is that it is fairly difficult to see what changed, how the new version would really look like, etc. Although GitHub gives you the possibility to see the differences in the code, and while that is probably perfectly enough when GitHub is used for code development, that is not satisfactory when HTML files are concerned.

I have configured, called PR Review (developed by Tobie Langel) which helps this. If you look at the latest PR[1], you will see, at the bottom of the comment, references to 'Preview' and to 'Diff'. The former provides a link to a preview (ie, with respec processed), and the latter shows a readable diff (not a diff on the html source but on the way the text has changed). (In this very case the latter is not necessary very useful because Matt has changed a lot but, in general, I believe that can be extremely useful, too). This links, and the modification of the comment to add these links, is done automatically. Note that if an extra commit is made on the branch that is to be PR-d, the links are automatically updated.

I cc-d Tobie to thank him for this tool. I believe it will make our life easier.



P.S. Some of you may have seen that there has been a bunch of seemingly unnecessary PR-s on the pwpub repository a few weeks ago: that was due to the fact that some problems with respec, related to this tool, came to the fore. However, Tobie and Marcos have successfully tracked this down and the tool is now operational.

[1] https://github.com/w3c/wpub/pull/43

Ivan Herman, W3C
Publishing@W3C Technical Lead
Home: http://www.w3.org/People/Ivan/
mobile: +31-641044153
ORCID ID: http://orcid.org/0000-0003-0782-2704

Received on Monday, 21 August 2017 15:58:01 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 16:52:16 UTC