- From: Matt Garrish <matt.garrish@gmail.com>
- Date: Mon, 21 Aug 2017 08:18:50 -0400
- To: "'Ivan Herman'" <ivan@w3.org>, "'W3C Publishing Working Group'" <public-publ-wg@w3.org>
- Cc: "'Tobie Langel'" <tobie@codespeaks.com>
Adding my praise for this new feature. So much easier to review pull requests now. And please have a look at the pull request Ivan mentioned.[1] It replaces the "abstract manifest" concept with an "infoset", and separates the manifest from the requirements of the infoset. It's not a radical departure from what existed before, but more an attempt at clarifying the necessary information about a web publication from the serialization of the information (which may not be complete because of user agent-compiled implicit/fallback information). [1] https://github.com/w3c/wpub/pull/43 Matt > -----Original Message----- > From: Ivan Herman [mailto:ivan@w3.org] > Sent: August 21, 2017 3:21 AM > To: W3C Publishing Working Group <public-publ-wg@w3.org> > Cc: Tobie Langel <tobie@codespeaks.com> > Subject: [Tooling] a new feature installed on our HTML/respec oriented > repositories > > One of the problems with the Pull Request mechanism is that it is fairly > difficult to see what changed, how the new version would really look like, etc. > Although GitHub gives you the possibility to see the differences in the code, > and while that is probably perfectly enough when GitHub is used for code > development, that is not satisfactory when HTML files are concerned. > > I have configured, called PR Review (developed by Tobie Langel) which helps > this. If you look at the latest PR[1], you will see, at the bottom of the > comment, references to 'Preview' and to 'Diff'. The former provides a link to > a preview (ie, with respec processed), and the latter shows a readable diff > (not a diff on the html source but on the way the text has changed). (In this > very case the latter is not necessary very useful because Matt has changed a > lot but, in general, I believe that can be extremely useful, too). This links, and > the modification of the comment to add these links, is done automatically. > Note that if an extra commit is made on the branch that is to be PR-d, the > links are automatically updated. > > I cc-d Tobie to thank him for this tool. I believe it will make our life easier. > > Cheers > > Ivan > > P.S. Some of you may have seen that there has been a bunch of seemingly > unnecessary PR-s on the pwpub repository a few weeks ago: that was due to > the fact that some problems with respec, related to this tool, came to the > fore. However, Tobie and Marcos have successfully tracked this down and > the tool is now operational. > > [1] https://github.com/w3c/wpub/pull/43 > > ---- > Ivan Herman, W3C > Publishing@W3C Technical Lead > Home: http://www.w3.org/People/Ivan/ > mobile: +31-641044153 > ORCID ID: http://orcid.org/0000-0003-0782-2704 >
Received on Monday, 21 August 2017 12:19:14 UTC