W3C home > Mailing lists > Public > public-pointer-events@w3.org > January to March 2014

RE: Status of review for PR-324

From: <Cathy.Chan@nokia.com>
Date: Mon, 24 Mar 2014 18:25:31 +0000
To: <rbyers@google.com>, <Art.Barstow@nokia.com>
CC: <Jacob.Rossi@microsoft.com>, <scott.gonzalez@gmail.com>, <public-pointer-events@w3.org>
Message-ID: <A46437648ECB3D4F852B077AFF9099F52941FC73@008-AM1MPN2-082.mgdnok.nokia.com>
I’ll commit to re-reviewing the files that I’ve reviewed.
Oh, and I’ll pick fortune. ;-)
- Cathy.

From: ext Rick Byers [mailto:rbyers@google.com]
Sent: Monday, March 24, 2014 10:59 AM
To: Barstow Art (Nokia-CTO/Boston)
Cc: Jacob Rossi; Scott González; public-pointer-events@w3.org
Subject: Re: Status of review for PR-324

Perhaps we could use the same division as last time?  I'm happy to re-review changes to files I've already reviewed once...

Rick

On Mon, Mar 24, 2014 at 10:37 AM, Arthur Barstow <art.barstow@nokia.com<mailto:art.barstow@nokia.com>> wrote:
Thanks for the update Jacob.

All - we need at least one reviewer and preferably more. Who is willing to commit to a review? Fame, fortune and a couple of "atta-{boy,girl}s" are sure to follow ;-).

-Thanks, ArtB


On 3/21/14 8:21 PM, ext Jacob Rossi wrote:
Hi again,

I've pushed a series of updates. These contain addressing feedback on touch-action cases as well as some tidying up of the test cases in general.  Note there were several file renames (to ensure consistency) and some whitespace changes (tab/space indent consistency) that might mess with your diffs a bit--sorry.

https://github.com/w3c/web-platform-tests/pull/324/commits


We'd appreciate a review so that we can hopefully land the PR to unblock the other testing action items.

There's probably an opportunity to speed up the tests (a few could have explicit done() calls to avoiding waiting for the timer). But I believe that isn't a blocker and we could follow that on as a separate PR if desired.

-Jacob

-----Original Message-----
From: Jacob Rossi
Sent: Wednesday, December 11, 2013 5:26 PM
To: Jacob Rossi; Rick Byers; Scott González
Cc: Arthur Barstow; public-pointer-events@w3.org<mailto:public-pointer-events@w3.org>
Subject: RE: Status of review for PR-324

Hi All,

We've updated PR-324 to address most of the feedback thus far [1]. Feedback that remains to be addressed AFAICT:

        - Consolidating tests into coarser granularity  (per this thread, Scott will take a look at this)
        -Feedback on recently submitted touch-action cases [2], we'll follow-up with another update to address these points

Thanks for all the great feedback. Let me know if we missed anything.

-Jacob

[1] https://github.com/w3c/web-platform-tests/pull/324

[2] https://github.com/InternetExplorer/web-platform-tests/commit/886568a445cded3b5aa01f0c8befb48e0534fed6



Received on Monday, 24 March 2014 18:26:34 UTC

This archive was generated by hypermail 2.3.1 : Tuesday, 6 January 2015 20:20:26 UTC