W3C home > Mailing lists > Public > public-pointer-events@w3.org > April to June 2014

Submitting additional pull requests

From: Jacob Rossi <Jacob.Rossi@microsoft.com>
Date: Wed, 7 May 2014 22:23:09 +0000
To: "public-pointer-events@w3.org" <public-pointer-events@w3.org>
Message-ID: <9557930786ff443da333b2d0b93399cf@BY2PR03MB457.namprd03.prod.outlook.com>
We're making great progress on getting pull request #324 reviewed and landed.  Part of what's been a challenge, I think, is how big the PR is and that we keep tacking on more tests to the PR as they've been developed.  

There's a few more test assertions we've been working on and will submit soon. To avoid further delaying landing #324, I'd prefer these new tests get submitted as their own separate pull requests. The only problem with this is that these new test cases depend on pointerevent_styles.css and pointerevent_support.js, which are in #324. 

What's the best way to accommodate this? I can see a few options:

1) Circumvent the review of #324, and go ahead commit the 2 common dependencies to w3c/web-platform-tests/master (I have write access to the W3C org).  If there are issues with those files themselves, we can file issues on the W3C repo.
2) Include the latest version of the 2 dependencies (from #324) in a new pull request with the new tests
3) Branch from submission/Microsoft/PointerEvents (#324) into a new branch  and make a new pull request from there.

I started option 3 (see https://github.com/InternetExplorer/web-platform-tests/tree/submission/Microsoft/PointerEvents2). But you'll note that if I submit a pull request to w3c/web-platform-tests/master, the diff will also include all of the changes from #324, which is less desirable. However, you can see just the new tests by diffing it with the submission/Microsoft/PointerEvents branch:

https://github.com/InternetExplorer/web-platform-tests/compare/submission%2FMicrosoft%2FPointerEvents...submission%2FMicrosoft%2FPointerEvents2 

Thoughts and suggestions welcomed! Happy to scrap what I started and use another approach if desired.

-Jacob
Received on Wednesday, 7 May 2014 22:23:39 UTC

This archive was generated by hypermail 2.3.1 : Tuesday, 6 January 2015 20:20:26 UTC