- From: Chris Blume (ProgramMax) <programmax@gmail.com>
- Date: Thu, 26 May 2022 18:55:09 -0400
- To: "Seeger, Chris (NBCUniversal)" <Chris.Seeger@nbcuni.com>
- Cc: Pierre-Anthony Lemieux <pal@sandflow.com>, "public-png@w3.org" <public-png@w3.org>
- Message-ID: <CAG3W2Kc7HJAbFW-_W3DS+efRpyj2W6EDAcs5kj2ZyXE7mpKSbw@mail.gmail.com>
I was able to squash your commits. But I was unable to push my changes onto your repo. Unfortunately, that is where the code review comments are. I was able to preserve your commit authorship and push it to my repo here: https://github.com/ProgramMax/PNG-spec/commits/add-iccn-chunk2 For the purpose of moving forward, I'll go ahead and address code review comments on this change and submit a replacement pull request. On Thu, May 26, 2022 at 3:42 PM Seeger, Chris (NBCUniversal) < Chris.Seeger@nbcuni.com> wrote: > Hi Chris, Pierre-Anthony, > > > > Is there anything you need from me at this point after the “squash”. > > > > Do I need to add/change a chunk as per the ongoing discussion? > > > > Best, > > Chris Seeger > > > > *From: *Chris Blume (ProgramMax) <programmax@gmail.com> > *Date: *Monday, May 16, 2022 at 8:15 AM > *To: *Pierre-Anthony Lemieux <pal@sandflow.com> > *Cc: *public-png@w3.org <public-png@w3.org> > *Subject: *[EXTERNAL] Re: [PNG] Cancel May 16th, 2022 meeting? > > Hello Pierre-Anthony, > > For iCCN, Chris Seeger has a patch out: > https://github.com/w3c/PNG-spec/pull/117 > <https://urldefense.com/v3/__https:/github.com/w3c/PNG-spec/pull/117__;!!PIZeeW5wscynRQ!tY7YDmN5QvCT2EljSFRv47bGC4gpJe1PrzUtUXJEw44emqBh8-PBXGL3WCEo2oOU4gWRBtVa0fgdSTJ9Zlf5$> > I'm helping him squash it, as per a review comment. (We ran into a problem > where Git really does not want to squash commits.) > Additionally, I need to go back through Color on the Web Community Group > history and convince myself that iCCM (iccMAX) is indeed an option for us. > That will end up changing the iCCN patch. > > So right now, I think I am the holdup. I'll try to unblock. > > > I do not think all "3rd edition" or even "2nd edition errata" issues are > blocking. For example, under "3rd edition" is an issue "Update figures". > That issue wants to both modernize some dated figure designs and fix text > clipping. (I looked into it and do not see a way in SVG to prevent that > text clipping.) The figures are usable as-is so this isn't a blocking > issue. This issue is more of a "nice to have". > > I think the only work left blocking the 3rd edition draft is the iCCN/iCCM > and ReSpec error cleanup. > > > Once I unblock the iCCN/iCCM patch, I'll update the issues with a more > clear blocking/nice-to-have indicator. > > > > On Mon, May 16, 2022 at 12:35 AM Pierre-Anthony Lemieux <pal@sandflow.com> > wrote: > > Hi Chris, > > Nothing urgent from me. > > What is blocking https://github.com/w3c/PNG-spec/issues/95 > <https://urldefense.com/v3/__https:/github.com/w3c/PNG-spec/issues/95__;!!PIZeeW5wscynRQ!tY7YDmN5QvCT2EljSFRv47bGC4gpJe1PrzUtUXJEw44emqBh8-PBXGL3WCEo2oOU4gWRBtVa0fgdSTVVWD33$> > ? > > Are all issues scheduled against "3rd edition" milestone [1] blocking? > > [1] https://github.com/w3c/PNG-spec/milestone/2 > <https://urldefense.com/v3/__https:/github.com/w3c/PNG-spec/milestone/2__;!!PIZeeW5wscynRQ!tY7YDmN5QvCT2EljSFRv47bGC4gpJe1PrzUtUXJEw44emqBh8-PBXGL3WCEo2oOU4gWRBtVa0fgdSVz0C7ST$> > > Best, > > -- Pierre > > On Fri, May 13, 2022 at 8:45 AM Chris Blume (ProgramMax) > <programmax@gmail.com> wrote: > > > > Hello everyone, > > > > It seems there are no new issues that need group discussion and thought. > > Unless someone has an idea for discussion, let's cancel the May 16th, > 2022 meeting. > >
Received on Thursday, 26 May 2022 22:55:34 UTC